Skip to content

feat: message forwarding #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
May 17, 2025
Merged

feat: message forwarding #2598

merged 41 commits into from
May 17, 2025

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Oct 6, 2024 •
edited by Lulalaby
Loading

Summary

Implements message forwarding, alongside some small cleanups for other message features.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion
Copy link
Member Author

NeloBlivion commented Oct 6, 2024 •
edited
Loading

more or less done, just need to add mention/role mention handling and partialmessage support... but still 403ing on my bot 😔

@Lulalaby
Copy link
Member

Lulalaby commented Oct 6, 2024 •
edited
Loading

unlucky bcs its 95% out. you're in th holdout group. try making a new bot

@JustaSqu1d JustaSqu1d added priority: medium Medium Priority feature Implements a feature API reflection Discord API isn't correctly reflected python Pull requests that update Python code labels Oct 21, 2024
@JustaSqu1d JustaSqu1d added this to the v2.7 milestone Nov 18, 2024
DA-344
DA-344 reviewed Nov 27, 2024
View reviewed changes
@Dorukyum
Copy link
Member

Dorukyum commented Jan 5, 2025

@NeloBlivion status?

Lulalaby
Lulalaby reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the status here, can this be tested and merged?

@Lulalaby Lulalaby requested review from Dorukyum and DA-344 February 28, 2025 19:20
@Lulalaby Lulalaby self-requested a review February 28, 2025 19:20
@NeloBlivion
Copy link
Member Author

As far as I've tested it operates fine, would appreciate others testing if they may know of any edge cases/weird behaviour with the attributes of ForwardedMessage but otherwise it's feature complete.

@NeloBlivion
Copy link
Member Author

(Actually haven't done a full review of docs so maybe that'd be a good idea)

DA-344
DA-344 approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@DA-344 DA-344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Paillat-dev
Paillat-dev approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS there a particular reason this is not getting merged ? Or is this ok di per se ?

JustaSqu1d
JustaSqu1d previously requested changes Mar 7, 2025
View reviewed changes
Lulalaby and others added 2 commits March 27, 2025 07:59
@Lulalaby @JustaSqu1d
Apply suggestions from code review
b78152a 
Co-authored-by: JustaSqu1d <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
@Lulalaby
Merge branch 'master' into forwarding
e4716ae 
Signed-off-by: Lala Sabathil <[email protected]>
@Paillat-dev
Copy link
Member

This pr should be marked as fixing

@Lulalaby Lulalaby linked an issue Mar 31, 2025 that may be closed by this pull request
Message Forwarding #2586
Closed
@Lulalaby
Copy link
Member

done but i still won't pay you

@NeloBlivion
Copy link
Member Author

pls merge this idk

@Lulalaby Lulalaby dismissed stale reviews from JustaSqu1d and Dorukyum May 17, 2025 13:46

x

@Lulalaby Lulalaby merged commit 9f383c7 into Pycord-Development:master May 17, 2025
28 checks passed
@Lulalaby
Copy link
Member

anything for u @NeloBlivion <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Paillat-dev Paillat-dev Paillat-dev approved these changes

@DA-344 DA-344 DA-344 approved these changes

@Lumabots Lumabots Lumabots approved these changes

@JustaSqu1d JustaSqu1d JustaSqu1d left review comments

@plun1331 plun1331 Awaiting requested review from plun1331

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees
No one assigned
Labels
API reflection Discord API isn't correctly reflected feature Implements a feature priority: medium Medium Priority python Pull requests that update Python code
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.

Message Forwarding
7 participants
@NeloBlivion @Lulalaby @Dorukyum @Paillat-dev @JustaSqu1d @DA-344 @Lumabots